gapan wrote:I think this is a problem (bug?) with xfce only. I don't remember gnome having any such problems. KDE certainly doesn't and neither does LXDE. That's the reason there is that "Rebuild icon cache" tool under the system menu in xfce too.
When we last made a significant change to the official Opera packages (.rpm, .deb and cross distro tar) the initial testing was done in Gnome and KDE. The shared parts of the post install instructions were done for the benefit of Gnome, i.e. the following:
- Code: Select all
# Setup menu entries
if command -v update-desktop-database >/dev/null 2>&1
update-desktop-database -q usr/share/applications
# Setup MIME associations
if command -v update-mime-database >/dev/null 2>&1
mkdir -p usr/share/mime/packages
update-mime-database usr/share/mime >/dev/null
# Setup icons
touch -c usr/share/icons/hicolor
if command -v update-icon-caches >/dev/null 2>&1
update-icon-caches -tq usr/share/icons/hicolor
elif command -v gtk-update-icon-cache >/dev/null 2>&1
gtk-update-icon-cache -tq usr/share/icons/hicolor
If memory serves KDE didn't really need any of this. I 'think' it just worked as soon as you placed the various files in the right locations (at least with recent KDE versions on the distros we tested). By the time we came to testing Xfce and others we already had these Gnome workarounds, so I can't really comment if Xfce or others needed them or not.
Things may have changed in Gnome since then and perhaps Xfce does display similar issues as you state. Either way I agree with you that the fact any of this needs to be done if is a bug and hence the post install is really just a work around for such bugs.
Of course without makepkg's '-p' the work around I am including in my Opera Slkbuild is effectively a waste of time. There might as well be no post install (other than symlink recreation). So you can see why I am keen to gain an easy way to access the '-p' option.
gapan wrote:In any case, maybe I'll make slkbuild use the -p option by default. I can't think of an harm in doing that.
I generally tend to agree. I can't really imagine it can cause to much harm. All it effectively does is promote symlinks to the same status as that of other files within the package. By that I mean they are all present before the rest of the post install, just like all other files and directories. I would think this could only be a good thing, especially where the post install instructions have been taken or based on those from packages of other non-Slackware based distros (like the Opera Slkbuild I posted), since the original authors of those post install instructions would have assumed those files where already in place.
Nonetheless it might be nice if there was some way to configure or switch this option on and off, just in case it has unintended consequences. I would hate to think that other packages became broken just because of a request I made! Anyway since you appear to be the author of Slkbuild I'll assume you know what is best and will make the right choice. Thanks for at least considering my thoughts.
I would also like to say if you are the author of Slkbuild, thanks so much it. It is a fantastic solution. I think it was wise to model on Arch's PKGBUILD. Additionally I don't think you could have done it more elegantly. I mean you could have skipped the intermediate step of converting to a regular build script first and to some this may have seemed like a good idea but your way gives two clear advantages. Firstly the build script can be shared with those who do not have Slkbuild installed and secondly final tweaks like my "sed 's:\(/sbin/makepkg\):\1 -p:' -i build-opera.sh" are always possible, meaning none of the power of a manually created build script is lost! So I just wanted to say well done!!
It also demonstrates to me that you Salix guys really know your stuff, something I had already begun to realise. I wonder if the next time I install 'Slackware' I might actually just install Salix. I honestly think I might!